Add feature flag treat-pod-as-always-schedulable #16146
Conversation
The feature flag allows to declare that Pods in the system will eventually all get scheduled and Revisions should therefore not be marked unschedulable Signed-off-by: Sascha Schwarze <[email protected]>
|
Hi @SaschaSchwarze0. Thanks for your PR. I'm waiting for a github.com member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
knative-prow
bot
added
size/M
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: SaschaSchwarze0 The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #16146 +/- ##
==========================================
- Coverage 80.09% 80.07% -0.02%
==========================================
Files 214 214
Lines 16932 16936 +4
==========================================
+ Hits 13561 13562 +1
- Misses 3014 3017 +3
Partials 357 357 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
knative-prow-robot
added
the
needs-rebase
|
PR needs rebase. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
dprotaso
left a comment
dprotaso
left a comment
There was a problem hiding this comment.
@SaschaSchwarze0 just some minor stuff.
Let's bring this change in and revisit whether we want to make any tweaks to this in the future.
Also To confirm we're still bound by the revision's progress deadline?
| # transient state. | ||
| # | ||
| # See https://github.com/knative/serving/issues/14862 | ||
| treat-pod-as-always-schedulable: "disabled" |
There was a problem hiding this comment.
Maybe something like?
| treat-pod-as-always-schedulable: "disabled" | |
| pod-are-always-schedulable: "disabled" |
There was a problem hiding this comment.
I think this knob should live in config-deployment - since this isn't about enabling a feature but more behaviour around how we treat deployments/pod status's - we have similar knobs (like progressiveDeadline etc there)
3 participants
Same as #15397 I had missed that that one was auto-closed.
The feature flag allows to declare that Pods in the system will eventually all get scheduled and Revisions should therefore not be marked unschedulable
Fixes #14862
Proposed Changes
Unfortunately, I never got feedback in above issue, so trying with a PR now:
treat-pod-as-always-schedulableis added with default Disabled.EDIT: there was some feedback in the issue in the meantime and it has since then also been auto-closed. @dprotaso @skonto you were involved in a few discussions there, but without real outcome. Appreciate clear feedback whether we can take this forward or not.
Release Note